Changeset 1080

Timestamp:

02/15/13 16:15:04 (12 years ago)

Author:

pharms

Message:

• prevented findbugs warnings

File:

• trunk/autoquest-plugin-jfc/src/main/java/de/ugoe/cs/autoquest/plugin/jfc/guimodel/JFCGUIElementSpec.java (modified) (3 diffs)

trunk/autoquest-plugin-jfc/src/main/java/de/ugoe/cs/autoquest/plugin/jfc/guimodel/JFCGUIElementSpec.java

@@ -115 +115 @@
         JFCGUIElementSpec otherSpec = (JFCGUIElementSpec) other;
 
-        if ((type != otherSpec.type) && ((type != null) && (!type.equals(otherSpec.type)))) {
+        if (type == null ? otherSpec.type != null : !type.equals(otherSpec.type)) {
             return false;
         }
 
-        if ((icon != otherSpec.icon) && ((icon != null) && (!icon.equals(otherSpec.icon)))) {
+        if (icon == null ? otherSpec.icon != null : !icon.equals(otherSpec.icon)) {
             return false;
         }
@@ -203 +203 @@
         JFCGUIElementSpec otherSpec = (JFCGUIElementSpec) other;
 
-        return ((name == otherSpec.name) || ((name != null) && (name.equals(otherSpec.name)))) &&
-            ((type == otherSpec.type) || ((type != null) && (type.equals(otherSpec.type)))) &&
-            ((icon == otherSpec.icon) || ((icon != null) && (icon.equals(otherSpec.icon)))) &&
+        return
+            (name == null ? otherSpec.name == null : name.equals(otherSpec.name)) &&
+            (type == null ? otherSpec.type == null : type.equals(otherSpec.type)) &&
+            (icon == null ? otherSpec.icon == null : icon.equals(otherSpec.icon)) &&
             (index == otherSpec.index) && (elementHash == otherSpec.elementHash);
     }
@@ -404 +405 @@
             }
 
-            if ((name != other.name) && (name != null) && (!name.equals(other.name))) {
+            if ((name == null) || (!name.equals(other.name))) {
                 setName(other.name);
             }