Changeset 1272 for trunk/autoquest-plugin-html

Timestamp:

07/25/13 15:27:21 (11 years ago)

Author:

pharms

Message:

• removed find bugs warnings

Location:

trunk/autoquest-plugin-html/src/main/java/de/ugoe/cs/autoquest/plugin/html

Files:

• HTMLLogCompressor.java (modified) (2 diffs)
• HTMLLogParser.java (modified) (1 diff)
• HTMLLogTextInputPseudomizer.java (modified) (1 diff)
• commands/CMDcorrectHTMLLogDirs.java (modified) (1 diff)

trunk/autoquest-plugin-html/src/main/java/de/ugoe/cs/autoquest/plugin/html/HTMLLogCompressor.java

@@ -189 +189 @@
                 while (finalOutFile.exists());
 
-                outFile.renameTo(finalOutFile);
-                Console.println("created " + finalOutFile);
+                if (outFile.renameTo(finalOutFile)) {
+                    Console.println("created " + finalOutFile);
+                }
+                else {
+                    Console.println
+                        ("created " + outFile + " but could not rename to " + finalOutFile);
+                }
             }
         }
         else {
-            outFile.delete();
+            if (!outFile.delete()) {
+                Console.printerrln
+                    ("could not delete temporary file " + outFile);
+            }
         }
     }
@@ -273 +281 @@
                     // add the event directly where the center is, as the timestamps of the center
                     // and the new event are equal
-                    start = end = center;
+                    end = center;
+                    start = end;
                     break;
                 }

trunk/autoquest-plugin-html/src/main/java/de/ugoe/cs/autoquest/plugin/html/HTMLLogParser.java

@@ -69 +69 @@
             // this is a server specification
             int port = 80;
-            String portStr = parameters.get(port);
+            String portStr = parameters.get("port");
             
             if (portStr != null) {

trunk/autoquest-plugin-html/src/main/java/de/ugoe/cs/autoquest/plugin/html/HTMLLogTextInputPseudomizer.java

@@ -242 +242 @@
                     // add the event directly where the center is, as the timestamps of the center
                     // and the new event are equal
-                    start = end = center;
+                    end = center;
+                    start = end;
                     break;
                 }

trunk/autoquest-plugin-html/src/main/java/de/ugoe/cs/autoquest/plugin/html/commands/CMDcorrectHTMLLogDirs.java

@@ -127 +127 @@
                     !file.getAbsolutePath().equals(destination.getAbsolutePath()))
                 {
-                    file.renameTo(destination);
-                
-                    Console.println("moved "  + file + " to " + destination);
-                
-                    if ((file.getParentFile().list() == null) ||
-                        (file.getParentFile().list().length == 0))
-                    {
-                        file.getParentFile().delete();
-                        Console.println("removed directory "  + file.getParentFile());
+                    if (file.renameTo(destination)) {
+                        Console.println("moved "  + file + " to " + destination);
+
+                        if ((file.getParentFile().list() == null) ||
+                            (file.getParentFile().list().length == 0))
+                        {
+                            if (file.getParentFile().delete()) {
+                                Console.println("removed directory "  + file.getParentFile());
+                            }
+                            else {
+                                Console.println
+                                    ("could not remove directory "  + file.getParentFile());                            
+                            }
+                        }
+                    }
+                    else {
+                        Console.println("could not move "  + file + " to " + destination);
                     }
                 }