Changeset 1292

Timestamp:

08/10/13 10:26:17 (11 years ago)

Author:

adeicke

Message:

Refactored filter mechanism.

Location:

trunk/autoquest-core-usability-evaluation/src/main/java/de/ugoe/cs/autoquest/usability/rules

Files:

• metrics/NoLetterOrDigitRatioMetric.java (modified) (2 diffs)
• metrics/TextInputEntryRepetitionsMetric.java (modified) (2 diffs)
• metrics/TextInputRatioMetric.java (modified) (2 diffs)
• patterns/InteractionPattern.java (modified) (3 diffs)

trunk/autoquest-core-usability-evaluation/src/main/java/de/ugoe/cs/autoquest/usability/rules/metrics/NoLetterOrDigitRatioMetric.java

@@ -28 +28 @@
 import de.ugoe.cs.autoquest.tasktrees.treeifc.ITaskModel;
 import de.ugoe.cs.autoquest.usability.EvaluationMethodCaller;
+import de.ugoe.cs.autoquest.usability.result.UsabilityProblemDescription;
 import de.ugoe.cs.autoquest.usability.result.UsabilityProblemDescriptionResolver;
-import de.ugoe.cs.autoquest.usability.result.UsabilityProblemDescription;
 import de.ugoe.cs.autoquest.usability.rules.UsabilityMetric;
 import de.ugoe.cs.autoquest.usability.rules.UsabilityRule;
 import de.ugoe.cs.autoquest.usability.taskmodel.filter.FilterResult;
-import de.ugoe.cs.autoquest.usability.taskmodel.filter.IterativeDFSFilterStrategy;
-import de.ugoe.cs.autoquest.usability.taskmodel.filter.types.TaskModelFilter;
+import de.ugoe.cs.autoquest.usability.taskmodel.filter.TaskModelFilter;
 
 /**
@@ -82 +81 @@
      */
     private FilterResult extractNodesFromTaskTree() {
-        return new TaskModelFilter(new IterativeDFSFilterStrategy()).filterByEventType(TEXT_INPUT)
-            .from(this.taskModel);
+        return new TaskModelFilter().filter(taskModel, TEXT_INPUT);
     }
 

trunk/autoquest-core-usability-evaluation/src/main/java/de/ugoe/cs/autoquest/usability/rules/metrics/TextInputEntryRepetitionsMetric.java

@@ -28 +28 @@
 import de.ugoe.cs.autoquest.tasktrees.treeifc.ITaskModel;
 import de.ugoe.cs.autoquest.usability.EvaluationMethodCaller;
+import de.ugoe.cs.autoquest.usability.result.UsabilityProblemDescription;
 import de.ugoe.cs.autoquest.usability.result.UsabilityProblemDescriptionResolver;
-import de.ugoe.cs.autoquest.usability.result.UsabilityProblemDescription;
 import de.ugoe.cs.autoquest.usability.rules.UsabilityMetric;
 import de.ugoe.cs.autoquest.usability.rules.UsabilityRule;
 import de.ugoe.cs.autoquest.usability.taskmodel.filter.FilterResult;
-import de.ugoe.cs.autoquest.usability.taskmodel.filter.IterativeDFSFilterStrategy;
-import de.ugoe.cs.autoquest.usability.taskmodel.filter.types.TaskModelFilter;
+import de.ugoe.cs.autoquest.usability.taskmodel.filter.TaskModelFilter;
 
 /**
@@ -82 +81 @@
      */
     private FilterResult extractNodesFromTaskTree() {
-        return new TaskModelFilter(new IterativeDFSFilterStrategy()).filterByEventType(TEXT_INPUT)
-            .from(this.taskModel);
+        return new TaskModelFilter().filter(taskModel, TEXT_INPUT);
     }
 

trunk/autoquest-core-usability-evaluation/src/main/java/de/ugoe/cs/autoquest/usability/rules/metrics/TextInputRatioMetric.java

@@ -27 +27 @@
 import de.ugoe.cs.autoquest.tasktrees.treeifc.ITaskModel;
 import de.ugoe.cs.autoquest.usability.EvaluationMethodCaller;
+import de.ugoe.cs.autoquest.usability.result.UsabilityProblemDescription;
 import de.ugoe.cs.autoquest.usability.result.UsabilityProblemDescriptionResolver;
-import de.ugoe.cs.autoquest.usability.result.UsabilityProblemDescription;
 import de.ugoe.cs.autoquest.usability.rules.UsabilityMetric;
 import de.ugoe.cs.autoquest.usability.rules.UsabilityRule;
 import de.ugoe.cs.autoquest.usability.taskmodel.filter.FilterResult;
-import de.ugoe.cs.autoquest.usability.taskmodel.filter.IterativeDFSFilterStrategy;
-import de.ugoe.cs.autoquest.usability.taskmodel.filter.types.TaskModelFilter;
+import de.ugoe.cs.autoquest.usability.taskmodel.filter.TaskModelFilter;
 
 /**
@@ -82 +81 @@
      */
     private FilterResult extractNodesFromTaskTree() {
-        return new TaskModelFilter(new IterativeDFSFilterStrategy()).filterByEventType(TEXT_INPUT)
-            .from(this.taskModel);
+        return new TaskModelFilter().filter(taskModel, TEXT_INPUT);
     }
 

trunk/autoquest-core-usability-evaluation/src/main/java/de/ugoe/cs/autoquest/usability/rules/patterns/InteractionPattern.java

@@ -21 +21 @@
 import com.google.common.collect.Iterables;
 
+import de.ugoe.cs.autoquest.tasktrees.treeifc.ISelection;
 import de.ugoe.cs.autoquest.tasktrees.treeifc.ITask;
 import de.ugoe.cs.autoquest.tasktrees.treeifc.ITaskModel;
-import de.ugoe.cs.autoquest.usability.taskmodel.filter.IterativeDFSFilterStrategy;
-import de.ugoe.cs.autoquest.usability.taskmodel.filter.types.TaskModelFilter;
+import de.ugoe.cs.autoquest.usability.taskmodel.filter.ITaskModelFilter;
+import de.ugoe.cs.autoquest.usability.taskmodel.filter.TaskModelFilter;
 import de.ugoe.cs.autoquest.usability.taskmodel.filter.types.TaskTypeFilter;
 
@@ -38 +39 @@
     /**
      * <p>
-     * {@link TaskModelFilter}, which is used to filter a task model after different {@link ITask}s
-     * </p>
-     */
-    private TaskModelFilter taskTreeFilter = new TaskModelFilter(new IterativeDFSFilterStrategy());
+     * {@link TaskModelFilterAccessor}, which is used to filter a task model after different {@link ITask}s
+     * </p>
+     */
+    private ITaskModelFilter taskTreeFilter = new TaskModelFilter();
 
     /**
@@ -188 +189 @@
      */
     private List<ITask> filterAllConcernedTasksFrom(ITaskModel taskModel) {
-        return this.taskTreeFilter.filterByNodeType(this.rootTask).from(taskModel)
-            .tasksMatchedFilter();
+        return this.taskTreeFilter.filter(taskModel, this.rootTask).tasksMatchedFilter();
     }