Changeset 1319 for trunk/autoquest-core-usability-evaluation/src

Timestamp:

11/08/13 22:34:21 (11 years ago)

Author:

khartmann

Message:

• Reworked Filters to use the first instance of a task to provide type and target
• Added a function to extract all tasks matching a given filter
• Added simple console feedback for matched usability problems

Location:

trunk/autoquest-core-usability-evaluation/src/main/java/de/ugoe/cs/autoquest/usability

Files:

• UsabilityEvaluator.java (modified) (2 diffs)
• result/UsabilityProblemDescription.java (modified) (1 diff)
• rules/UsabilityMetricsRuleset.java (modified) (1 diff)
• rules/patterns/InteractionPattern.java (modified) (9 diffs)
• rules/patterns/InteractionPatternVisitor.java (modified) (3 diffs)
• taskmodel/filter/types/EventTargetFilter.java (modified) (2 diffs)
• taskmodel/filter/types/EventTypeFilter.java (modified) (2 diffs)
• util/NullTask.java (modified) (2 diffs)
• util/TextInputUtil.java (modified) (3 diffs)

trunk/autoquest-core-usability-evaluation/src/main/java/de/ugoe/cs/autoquest/usability/UsabilityEvaluator.java

@@ -77 +77 @@
                 rule.callEvaluationMethod(evaluationMethodCaller);
             if (defect.isPresent()) {
-                result.addProblem(defect.get());
+                UsabilityProblemDescription description = defect.get();
+                logUsabilityProblem(description);
+                result.addProblem(description);
             }
         }
@@ -83 +85 @@
     }
 
+    private void logUsabilityProblem(UsabilityProblemDescription description) {
+        Level level = null;
+        switch (description.getSeverityLevel()) {
+            case NONE:
+                break;
+            case INFO:
+            case LOW:
+                level = Level.INFO;
+                break;
+            case MEDIUM:
+            case HIGH:
+                level = Level.WARNING;
+        }
+        if (level != null) {
+            Console.print(description.getSeverityLevel().toString());
+            Console.print(" : ");
+            Console.println(description.toString());
+            //Console.traceln(level, description.toString());
+        }
+    }
+
 }

trunk/autoquest-core-usability-evaluation/src/main/java/de/ugoe/cs/autoquest/usability/result/UsabilityProblemDescription.java

@@ -85 +85 @@
     }
 
+    @Override
+    public String toString() {
+        return this.description;
+    }
+    
     /**
      * <p>

trunk/autoquest-core-usability-evaluation/src/main/java/de/ugoe/cs/autoquest/usability/rules/UsabilityMetricsRuleset.java

@@ -42 +42 @@
      * 
      */
-    private UsabilityMetricsRuleset(ITaskModel taskModel) {
+    public UsabilityMetricsRuleset(ITaskModel taskModel) {
         this.metrics = Lists.newArrayList();
         metrics.add(new NoLetterOrDigitRatioMetric(taskModel));

trunk/autoquest-core-usability-evaluation/src/main/java/de/ugoe/cs/autoquest/usability/rules/patterns/InteractionPattern.java

@@ -15 +15 @@
 package de.ugoe.cs.autoquest.usability.rules.patterns;
 
+import java.util.Collection;
+import java.util.Iterator;
 import java.util.List;
 
@@ -107 +109 @@
      * 
      * <p>
+     * Returns all tasks of the given task model matching the provided interaction pattern.
+     * </p>
+     * 
+     * @param taskModel
+     *            {@link ITaskModel}, which might contain the interaction pattern
+     * @return all tasks matched
+     */
+    public Collection<ITask> matchingTasks(ITaskModel taskModel) {
+        List<ITask> allConcernedTasks = filterAllConcernedTasksFrom(taskModel);
+        for (Iterator<ITask> iterator = allConcernedTasks.iterator(); iterator.hasNext();) {
+            ITask concernedTask = iterator.next();
+            checkTask(concernedTask);
+            if (this.present)
+                this.present = false;
+            else
+                iterator.remove();
+        }
+        return allConcernedTasks;
+    }
+
+    /**
+     * 
+     * <p>
      * Checks a single {@link ITask} for the interaction pattern.
      * </p>
@@ -114 +139 @@
      */
     private void checkTask(ITask task) {
+        System.out.println("+++++++++++++++");
+        System.out.println(task);
+        System.out.println(this);
+        System.out.println(this.patternVisitors);
         applyAllVisitors(task);
+        System.out.println("------------");
         if (allVisitorsArePresent()) {
             this.present = true;
@@ -121 +151 @@
             resetAllVisitors();
         }
+        System.out.println("^^^^^^^^^^^^");
     }
 
@@ -134 +165 @@
      */
     public boolean containedIn(ITask task) {
+        System.out.println('>');
         checkTask(task);
+        System.out.println("< "+this.present);
         return this.present;
     }
@@ -151 +184 @@
         Optional<InteractionPatternVisitor> previousVisitor = Optional.absent();
         for (InteractionPatternVisitor visitor : patternVisitors) {
+            System.out.print(visitor+" ");
             if (appliedOnSelectionNode(previousVisitor)) {
+                System.out.println("Selection");
                 for (ITask selection : previousVisitor.get().getRetainedSelectionNodes()) {
                     selection.accept(visitor);
@@ -157 +192 @@
             }
             else {
+                System.out.println("Normal");
                 previousVisitor = Optional.of(visitor);
                 task.accept(visitor);
             }
+            System.out.println(visitor.isPresent() ? '1' : '0');
         }
     }
@@ -208 +245 @@
 
             });
-        return Iterables.size(allPresent) == this.patternVisitors.size();
+        int cnt = Iterables.size(allPresent);
+        System.out.printf("%d/%d\n", cnt, this.patternVisitors.size());
+        return cnt == this.patternVisitors.size();
     }
 
@@ -218 +257 @@
      */
     private void resetAllVisitors() {
+        System.out.println("+RESET+");
         for (InteractionPatternVisitor visitor : this.patternVisitors) {
             visitor.reset();

trunk/autoquest-core-usability-evaluation/src/main/java/de/ugoe/cs/autoquest/usability/rules/patterns/InteractionPatternVisitor.java

@@ -20 +20 @@
 
 import com.google.common.base.Splitter;
+import com.google.common.collect.Iterables;
 import com.google.common.collect.Lists;
 
+import de.ugoe.cs.autoquest.eventcore.Event;
 import de.ugoe.cs.autoquest.eventcore.IEventTarget;
 import de.ugoe.cs.autoquest.eventcore.IEventType;
 import de.ugoe.cs.autoquest.eventcore.StringEventType;
 import de.ugoe.cs.autoquest.tasktrees.treeifc.IEventTask;
+import de.ugoe.cs.autoquest.tasktrees.treeifc.IEventTaskInstance;
 import de.ugoe.cs.autoquest.tasktrees.treeifc.IIteration;
 import de.ugoe.cs.autoquest.tasktrees.treeifc.IOptional;
@@ -31 +34 @@
 import de.ugoe.cs.autoquest.tasktrees.treeifc.ISequence;
 import de.ugoe.cs.autoquest.tasktrees.treeifc.ITask;
+import de.ugoe.cs.autoquest.tasktrees.treeifc.ITaskInstance;
 import de.ugoe.cs.autoquest.tasktrees.treeifc.ITaskVisitor;
 import de.ugoe.cs.autoquest.test.DummyGUIElement;
@@ -67 +71 @@
     public void visit(IEventTask event) {
         if (!this.present && isEventVisitor()) {
-                boolean matchesEventType = matchesEventType(event.getEventType());
-                boolean matchesEventTarget = matchesEventTarget(event.getEventTarget());
+                Event eventRepresentative = ((IEventTaskInstance) event.getInstances().iterator().next()).getEvent();
+                boolean matchesEventType = matchesEventType(eventRepresentative.getType());
+                boolean matchesEventTarget = matchesEventTarget(eventRepresentative.getTarget());
                 this.present = eventTarget != null ? matchesEventType && matchesEventTarget : matchesEventType;
         }
+        System.out.printf("%s [%s, %s, %s]: %s\n", event, this.eventType, this.eventTarget, this.taskType, this.present);
+        System.out.println(this.getClass().getSimpleName() + " "+ this.hashCode());
     }
 

trunk/autoquest-core-usability-evaluation/src/main/java/de/ugoe/cs/autoquest/usability/taskmodel/filter/types/EventTargetFilter.java

@@ -24 +24 @@
 import de.ugoe.cs.autoquest.plugin.html.guimodel.HTMLText;
 import de.ugoe.cs.autoquest.tasktrees.treeifc.IEventTask;
+import de.ugoe.cs.autoquest.tasktrees.treeifc.IEventTaskInstance;
 import de.ugoe.cs.autoquest.tasktrees.treeifc.ITask;
+import de.ugoe.cs.autoquest.tasktrees.treeifc.ITaskInstance;
 
 /**
@@ -85 +87 @@
             @Override
             public IEventTarget apply(ITask task) {
-                return ((IEventTask) task).getEventTarget();
+                // XXX: Use the type of the first instance provided
+                ITaskInstance firstInstance = task.getInstances().iterator().next();
+                return ((IEventTaskInstance) firstInstance).getEvent().getTarget();
             }
         };

trunk/autoquest-core-usability-evaluation/src/main/java/de/ugoe/cs/autoquest/usability/taskmodel/filter/types/EventTypeFilter.java

@@ -28 +28 @@
 import de.ugoe.cs.autoquest.eventcore.gui.TextInput;
 import de.ugoe.cs.autoquest.tasktrees.treeifc.IEventTask;
+import de.ugoe.cs.autoquest.tasktrees.treeifc.IEventTaskInstance;
 import de.ugoe.cs.autoquest.tasktrees.treeifc.ITask;
+import de.ugoe.cs.autoquest.tasktrees.treeifc.ITaskInstance;
 
 /**
@@ -97 +99 @@
             @Override
             public IEventType apply(ITask task) {
-                return ((IEventTask) task).getEventType();
+                // XXX: Use the type of the first instance provided
+                ITaskInstance firstInstance = task.getInstances().iterator().next();
+                return ((IEventTaskInstance) firstInstance).getEvent().getType();
             }
         };

trunk/autoquest-core-usability-evaluation/src/main/java/de/ugoe/cs/autoquest/usability/util/NullTask.java

@@ -15 +15 @@
 package de.ugoe.cs.autoquest.usability.util;
 
+import java.util.Collection;
+import java.util.Collections;
+
 import org.apache.commons.lang.StringUtils;
 
 import de.ugoe.cs.autoquest.tasktrees.treeifc.ITask;
+import de.ugoe.cs.autoquest.tasktrees.treeifc.ITaskInstance;
 import de.ugoe.cs.autoquest.tasktrees.treeifc.ITaskVisitor;
 
@@ -91 +95 @@
     }
 
+    @Override
+    public Collection<ITaskInstance> getInstances() {
+        // return nothing
+        return Collections.emptyList();
+    }
+
 }

trunk/autoquest-core-usability-evaluation/src/main/java/de/ugoe/cs/autoquest/usability/util/TextInputUtil.java

@@ -26 +26 @@
 
 import de.ugoe.cs.autoquest.eventcore.gui.TextInput;
-import de.ugoe.cs.autoquest.tasktrees.treeifc.IEventTask;
+import de.ugoe.cs.autoquest.tasktrees.treeifc.IEventTaskInstance;
 import de.ugoe.cs.autoquest.tasktrees.treeifc.ITask;
+import de.ugoe.cs.autoquest.tasktrees.treeifc.ITaskInstance;
 
 /**
@@ -45 +46 @@
      * 
      * <p>
-     * Returns all entered words and signs of text input events.
+     * Returns all entered words and signs of all instances of text input events.
      * </p>
      * 
@@ -56 +57 @@
         List<Iterable<String>> allTextInputs = Lists.newArrayList();
         for (ITask taskWithTextInput : tasksWithTextInputEvents) {
-            TextInput textInput = (TextInput) ((IEventTask) taskWithTextInput).getEventType();
-            allTextInputs.add(splitTextIntoWordsAndSigns(textInput.getEnteredText()));
+            System.out.print("+");
+            for (ITaskInstance instance : taskWithTextInput.getInstances()) {
+                System.out.print(".");
+                TextInput textInput =
+                    (TextInput) ((IEventTaskInstance) instance).getEvent().getType();
+                allTextInputs.add(splitTextIntoWordsAndSigns(textInput.getEnteredText()));
+            }
+            System.out.println("");
         }
+        System.out.println(allTextInputs);
         return HashMultiset.create(Iterables.concat(allTextInputs));
     }