Changeset 1362 for trunk/autoquest-core-tasktrees

Timestamp:

02/07/14 19:09:08 (11 years ago)

Author:

pharms

Message:

• prevented a Nullpointer
• corrected removal of instances of a task in case an instance is assigned a new task

File:

• trunk/autoquest-core-tasktrees/src/main/java/de/ugoe/cs/autoquest/tasktrees/treeimpl/TaskBuilder.java (modified) (2 diffs)

trunk/autoquest-core-tasktrees/src/main/java/de/ugoe/cs/autoquest/tasktrees/treeimpl/TaskBuilder.java

@@ -192 +192 @@
         if (!(instance instanceof SelectionInstance)) {
             throw new IllegalArgumentException
-                ("illegal type of sequence instance provided: " + instance.getClass());
+                ("illegal type of selection instance provided: " + instance.getClass());
         }
 
         if (!(child instanceof TaskInstance)) {
-            throw new IllegalArgumentException
-                ("illegal type of task instance provided: " + child.getClass());
+            throw new IllegalArgumentException("illegal type of task instance provided: " +
+                                               (child == null ? null : child.getClass()));
         }
         
@@ -353 +353 @@
                 ("illegal type of task instance provided: " + taskInstance.getClass());
         }
-        
+        if (!(task instanceof Task)) {
+            throw new IllegalArgumentException("illegal type of task provided: " + task.getClass());
+        }
+        
+        if (((TaskInstance) taskInstance).getTask() instanceof Task) {
+            ((Task) ((TaskInstance) taskInstance).getTask()).removeInstance(taskInstance);
+        }
         ((TaskInstance) taskInstance).setTask(task);
+        
+        ((Task) task).addInstance(taskInstance);
     }