Index: /trunk/autoquest-plugin-android/.classpath =================================================================== --- /trunk/autoquest-plugin-android/.classpath (revision 1868) +++ /trunk/autoquest-plugin-android/.classpath (revision 1869) @@ -17,4 +17,10 @@ + + + + + + Index: /trunk/autoquest-plugin-android/src/main/java/de/ugoe/cs/autoquest/plugin/android/AndroidLogParser.java =================================================================== --- /trunk/autoquest-plugin-android/src/main/java/de/ugoe/cs/autoquest/plugin/android/AndroidLogParser.java (revision 1868) +++ /trunk/autoquest-plugin-android/src/main/java/de/ugoe/cs/autoquest/plugin/android/AndroidLogParser.java (revision 1869) @@ -154,7 +154,7 @@ /** - * - */ - private Boolean showSteps = false; + * Show parsed elements to find out failures. + */ + private Boolean showSteps = true; /** @@ -303,5 +303,5 @@ currentGUIElementHash = Long.parseLong(atts.getValue("hash")); currentGUIElementSpec = new ANDROIDGUIElementSpec(); - currentGUIElementSpec.setHashCode((int) currentGUIElementHash.longValue()); + currentGUIElementSpec.setElementHash((int) currentGUIElementHash.longValue()); } @@ -315,4 +315,7 @@ if ("class".equals(atts.getValue("name"))) { currentGUIElementSpec.setType(atts.getValue("value")); + } + else if ("title".equals(atts.getValue("name"))) { + currentGUIElementSpec.setName(atts.getValue("value")); } else if ("path".equals(atts.getValue("name"))) { Index: /trunk/autoquest-plugin-android/src/main/java/de/ugoe/cs/autoquest/plugin/android/guimodel/ANDROIDGUIElement.java =================================================================== --- /trunk/autoquest-plugin-android/src/main/java/de/ugoe/cs/autoquest/plugin/android/guimodel/ANDROIDGUIElement.java (revision 1868) +++ /trunk/autoquest-plugin-android/src/main/java/de/ugoe/cs/autoquest/plugin/android/guimodel/ANDROIDGUIElement.java (revision 1869) @@ -101,4 +101,59 @@ return "Android"; } + + /** + *

+ * Returns the type of the GUI element, i.e., the name of its Android class. + *

+ * + * @return the Android class name + */ + public String getAndroidType() { + return specification.getType(); + } + + /** + *

+ * Returns the name of the GUI element. + *

+ * + * @return the name + */ + public String getName() { + return specification.getName(); + } + + /** + *

+ * Returns the path of the GUI element. + *

+ * + * @return the path + */ + public String getPath() { + return specification.getPath(); + } + + /** + *

+ * Returns the GUI element identifier. + *

+ * + * @return identifier of the GUI element + */ + int getIndex() { + return specification.getIndex(); + } + + /** + *

+ * Returns the object hash of the GUI element. + *

+ * + * @return the object hash + */ + int getElementHash() { + return specification.getElementHash(); + } /* @@ -113,4 +168,17 @@ return str + "<-" + getParent().getStringIdentifier(); } + return str; + } + + /* + * (non-Javadoc) + * + * @see java.lang.Object#toString() + */ + @Override + public String toString() { + String str = + getElementDescriptor() + "(" + getName() + "," + getElementHash() + "," + getPath() + + "," + getIndex() + ")"; return str; } Index: /trunk/autoquest-plugin-android/src/main/java/de/ugoe/cs/autoquest/plugin/android/guimodel/ANDROIDGUIElementSpec.java =================================================================== --- /trunk/autoquest-plugin-android/src/main/java/de/ugoe/cs/autoquest/plugin/android/guimodel/ANDROIDGUIElementSpec.java (revision 1868) +++ /trunk/autoquest-plugin-android/src/main/java/de/ugoe/cs/autoquest/plugin/android/guimodel/ANDROIDGUIElementSpec.java (revision 1869) @@ -31,5 +31,5 @@ /** *

- * default serial version UID + * Default serial version UID *

*/ @@ -37,5 +37,7 @@ /* - * (non-Javadoc) see de.ugoe.cs.autoquest.androidmonitor.AndroidmonitorLogFile#logComponent() + * (non-Javadoc) + * + * @see de.ugoe.cs.autoquest.androidmonitor.AndroidmonitorLogFile#logComponent() */ /** @@ -46,5 +48,5 @@ *

*/ - private int hashCode; + private int elementHash; /** @@ -56,7 +58,12 @@ private String path; - /** - *

- * id of the object as it is returned by view.getId() + /* + * (non-Javadoc) + * + * @see http://developer.android.com/reference/android/view/View.html#getId() + */ + /** + *

+ * Id of the object as it is returned by view.getId(). *

*/ @@ -65,6 +72,12 @@ /** *

- * the type of GUI element represented by this specification, which is usually the java class of - * the android GUI element + * Current name of the GUI element + *

+ */ + private String name; + + /** + *

+ * The type of GUI element, i.e., the class of the android GUI element. *

*/ @@ -73,8 +86,61 @@ /** *

- * Type hierarchy of the class itself + * Type hierarchy of the class itself. *

*/ private List typeHierarchy = null; + + /* + * (non-Javadoc) + * + * @see + * de.ugoe.cs.autoquest.eventcore.guimodel.IGUIElementSpec#getSecificationSimilarity(IGUIElementSpec + * ) + */ + @Override + public boolean getSimilarity(IGUIElementSpec other) { + if (this == other) { + return true; + } + + if (!(other instanceof ANDROIDGUIElementSpec)) { + return false; + } + + ANDROIDGUIElementSpec otherSpec = (ANDROIDGUIElementSpec) other; + + if (type == null ? otherSpec.type != null : !type.equals(otherSpec.type)) { + return false; + } + + /* + * Up to now, we compared, if the basics match. Due to testing with different virtual + * devices it seems to be the case that the id of a view (named index here) keeps the same + * even on different devices even if the hashCode changes. Some of the GUI elements does not + * have an id (id is -1). + */ + + if (otherSpec.index > 1 && index == otherSpec.index) { + return true; + } + + /* + * Two elements could also be similar if the path of the elements is equal and the name is + * set, equal and not equal to "image:" even if index <= 1. This comparison is not + * implemented up to know due to the reason that all recorded elements up to 2015/01 either + * have an index > 1 or no name to be compared. + * + * In all other cases up to know it is not clear if two elements are similar. + * + * Not working: + * + * - Position of the elements: Due to the reason that there are a lot of different displays + * on the android market and the in the most cases the layout depends on the display size + * (different resolutions) similar elements have different positions. + */ + + return false; + } + /* @@ -102,7 +168,126 @@ return typeHierarchy.toArray(new String[typeHierarchy.size()]); } - - @Override - public boolean getSimilarity(IGUIElementSpec other) { + + /** + *

+ * Returns the object hash of the specified GUI element. + *

+ * + * @return the elementHash + */ + public int getElementHash() { + return elementHash; + } + + /** + *

+ * Returns the path associated with the specified GUI element. + *

+ * + * @return the path to an element + */ + public String getPath() { + return path; + } + + /** + *

+ * Returns the GUI element identifier. + *

+ * + * @return identifier of the GUI element + */ + public int getIndex() { + return index; + } + + /** + *

+ * Returns the name of the specified GUI element. Displayed text in the application or image + * name. + *

+ * + * @return text or image of the GUI element. + */ + public String getName() { + if (name == null || name.trim().length() == 0) { + return "NOT_SET"; + } + return name; + } + + /** + *

+ * Sets the GUI element identifier. + *

+ * + * @param indentifier + */ + public void setIndex(int index) { + this.index = index; + } + + /** + * Set the hash code associated with the GUI element. + * + * @param hash + * the hash of an element object + */ + public void setElementHash(int hash) { + this.elementHash = hash; + } + + /** + * Set the path associated with the specified GUI element. + * + * @param path + * the path to an element + */ + public void setPath(String path) { + this.path = path; + } + + /** + *

+ * Sets the type of the specified GUI element. + *

+ * + * @param type + * the type + */ + public void setType(String type) { + this.type = type; + } + + /** + *

+ * Sets the name of the specified GUI element. Displayed text in the application or image name. + *

+ * + * @param name + * the name + */ + public void setName(String name) { + this.name = name; + } + + /** + *

+ * Sets the type hierarchy of the specified GUI element. + * + * @param typeHierarchy + *

+ */ + public void setTypeHierarchy(List typeHierarchy) { + this.typeHierarchy = typeHierarchy; + } + + /* + * (non-Javadoc) + * + * @see de.ugoe.cs.autoquest.eventcore.guimodel.IGUIElementSpec#equals(IGUIElementSpec) + */ + @Override + public boolean equals(Object other) { if (this == other) { return true; @@ -113,86 +298,34 @@ } - // Check wheter view.id() keeps the same even if something in the - // structure changes. The hash in the JFCMonitor seems to be unique at - // all. In the Androidmonitore the hash of an element changes even from - // one start of the activity to another. + ANDROIDGUIElementSpec otherSpec = (ANDROIDGUIElementSpec) other; + + return (elementHash == otherSpec.elementHash) && + (path == null ? otherSpec.path == null : path.equals(otherSpec.path)) && + (index == otherSpec.index) && + (name == null ? otherSpec.name == null : name.equals(otherSpec.name)) && + (type == null ? otherSpec.type == null : type.equals(otherSpec.type)); + } + + /* + * (non-Javadoc) + * + * @see java.lang.Object#hashCode() + */ + @Override + public int hashCode() { + // 17 due to the reason that this is a prime number. + int result = 17; /* - * Maybe some other comparisons will be necessary in the future. + * 31 due to the reason that a lot of VM's could optimize this multiplication by a shift. + * Source: Effective Java, Joshua Bloch, 2008, p.48 */ - - return false; - } - - /* - * (non-Javadoc) - * - * @see java.lang.Object#hashCode() - */ - @Override - public int hashCode() { - return hashCode; - } - - /** - *

- * Returns the path associated with the specified GUI element. - *

- * - * @return the path to an element - */ - public String getPath() { - return path; - } - - public int getIndex() { - return index; - } - - public void setIndex(int index) { - this.index = index; - } - - /** - * Set the hash code associated with the GUI element. - * - * @param hash - * the hash of an element object - */ - public void setHashCode(int hash) { - this.hashCode = hash; - } - - /** - * Set the path associated with the specified GUI element. - * - * @param path - * the path to an element - */ - public void setPath(String path) { - this.path = path; - } - - /** - *

- * Sets the type of the specified GUI element. - *

- * - * @param type - * the type - */ - public void setType(String type) { - this.type = type; - } - - /** - *

- * Sets the type hierarchy of the specified GUI element. - * - * @param typeHierarchy - *

- */ - public void setTypeHierarchy(List typeHierarchy) { - this.typeHierarchy = typeHierarchy; - } + result = 31 * result + elementHash; + result = 31 * result + path.hashCode(); + result = 31 * result + index; + result = 31 * result + getName().hashCode(); + result = 31 * result + type.hashCode(); + return result; + } + }