Changeset 1960 for trunk/autoquest-core-usability/src

Timestamp:

06/02/15 13:17:55 (10 years ago)

Author:

pharms

Message:

• correction in smell detection

File:

• trunk/autoquest-core-usability/src/main/java/de/ugoe/cs/autoquest/usability/DataEntryMethodChangeRule.java (modified) (3 diffs)

trunk/autoquest-core-usability/src/main/java/de/ugoe/cs/autoquest/usability/DataEntryMethodChangeRule.java

@@ -92 +92 @@
      */
     private Map<ITask, Integer> getDataEntryMethodChangeRatios(Collection<ITask> tasks) {
-        Map<ITask, Integer> impatienceRatios = new HashMap<ITask, Integer>();
+        Map<ITask, Integer> methodChangeRatios = new HashMap<ITask, Integer>();
         
         for (ITask task : tasks) {
@@ -99 +99 @@
                 
                 if (ratio > 0) {
-                    impatienceRatios.put(task, ratio);
+                    methodChangeRatios.put(task, ratio);
                 }
             }
         }
         
-        return impatienceRatios;
+        return methodChangeRatios;
     }
 
@@ -142 +142 @@
 
             for (IEventTaskInstance current : terminalNodes) {
-                if (previous == null) {
-                    previous = current;
-                }
-                else if (dataEntryMethodChanges(previous, current)) {
+                if ((previous != null) && (dataEntryMethodChanges(previous, current))) {
                     changeCount++;
                 }
+                
+                previous = current;
             }