Changeset 253

Timestamp:

10/12/11 22:26:16 (13 years ago)

Author:

sherbold

Message:

• improved handling of bad input values for methods of de.ugoe.cs.eventbench.models.IncompleMemory?

File:

• trunk/EventBenchCore/src/de/ugoe/cs/eventbench/models/IncompleteMemory.java (modified) (3 diffs)

trunk/EventBenchCore/src/de/ugoe/cs/eventbench/models/IncompleteMemory.java

@@ -1 +1 @@
 package de.ugoe.cs.eventbench.models;
 
+import java.security.InvalidParameterException;
 import java.util.LinkedList;
 import java.util.List;
@@ -40 +41 @@
          * @param length
          *            number of recent events that are remembered
+         * @throws InvalidParameterException
+         *             This exception is thrown if the length is smaller than 1
          */
         public IncompleteMemory(int length) {
+                if (length < 1) {
+                        throw new InvalidParameterException(
+                                        "Length of IncompleteMemory must be at least 1.");
+                }
                 this.length = length;
                 history = new LinkedList<T>();
@@ -66 +73 @@
         @Override
         public List<T> getLast(int num) {
-                return new LinkedList<T>(history); // defensive copy
+                if( num<1 ) {
+                        return new LinkedList<T>();
+                } else {
+                return new LinkedList<T>(history.subList(
+                                Math.max(0, history.size() - num),
+                                history.size())); // defensive copy
+                }
         }