Changeset 347 for trunk/JFCMonitor/src/de/ugoe/cs/eventbench

Timestamp:

01/05/12 15:42:48 (13 years ago)

Author:

sherbold

Message:

• strings in the output written by the JFCMonitor are now sanitized for usage with XML, i.e., <,>,&,'," are replaced by their respective XML entities

File:

• trunk/JFCMonitor/src/de/ugoe/cs/eventbench/jfcmonitor/JFCListener.java (modified) (7 diffs)

trunk/JFCMonitor/src/de/ugoe/cs/eventbench/jfcmonitor/JFCListener.java

@@ -10 +10 @@
 import java.lang.reflect.InvocationTargetException;
 import java.lang.reflect.Method;
+
+import de.ugoe.cs.util.StringTools;
 
 /**
@@ -39 +41 @@
                 this.outputWriter = outputWriter;
                 try {
-                        outputWriter.write("<?xml version=\"1.0\" encoding=\"UTF-16\"?>" + ENDLINE);
+                        outputWriter.write("<?xml version=\"1.0\" encoding=\"UTF-16\"?>"
+                                        + ENDLINE);
                         outputWriter.write("<sessions>" + ENDLINE);
                 } catch (IOException e) {
@@ -111 +114 @@
                 builder.append(" <source>" + ENDLINE);
                 builder.append("  <param name=\"toString\" value=\""
-                                + event.getSource().toString() + "\" />" + ENDLINE);
+                                + StringTools
+                                                .xmlEntityReplacement(event.getSource().toString())
+                                + "\" />" + ENDLINE);
                 if (event.getSource() instanceof Component) {
                         Component source = (Component) event.getSource();
@@ -135 +140 @@
         private void addComponentInfo(StringBuilder builder, Component component) {
                 builder.append("  <param name=\"getName\" value=\""
-                                + component.getName() + "\" />" + ENDLINE);
+                                + StringTools.xmlEntityReplacement(component.getName())
+                                + "\" />" + ENDLINE);
                 for (Method method : component.getClass().getMethods()) {
                         try {
@@ -141 +147 @@
                                         String text = (String) method.invoke(component,
                                                         new Object[] {});
-                                        if( text!=null ) {
-                                                builder.append("  <param name=\"getText\" value=\"" + text + "\" />" + ENDLINE);
+                                        if (text != null) {
+                                                builder.append("  <param name=\"getText\" value=\""
+                                                                + StringTools.xmlEntityReplacement(text)
+                                                                + "\" />" + ENDLINE);
                                         }
                                 }
@@ -148 +156 @@
                                         String title = (String) method.invoke(component,
                                                         new Object[] {});
-                                        if( title!=null ) {
-                                                builder.append("  <param name=\"getTitle\" value=\"" + title + "\" />" + ENDLINE);
+                                        if (title != null) {
+                                                builder.append("  <param name=\"getTitle\" value=\""
+                                                                + StringTools.xmlEntityReplacement(title)
+                                                                + "\" />" + ENDLINE);
                                         }
                                 }
@@ -155 +165 @@
                         } catch (IllegalAccessException e) {
                         } catch (InvocationTargetException e) {
-                                System.err.println("Found method with name " + method.getName() + " but could not access it.");
+                                System.err.println("Found method with name " + method.getName()
+                                                + " but could not access it.");
                         }
                 }