Changeset 772

Timestamp:

09/05/12 15:53:38 (12 years ago)

Author:

sherbold

Message:

• updated QuestPlugin? API and implementing plug-ins to ensure that the internal representation is immutable from the outside.

Location:

trunk

Files:

• quest-plugin-core-test/src/test/java/de/ugoe/cs/quest/plugin/PluginLoaderTest.java (modified) (2 diffs)
• quest-plugin-core-test/testdata/de.ugoe.cs.quest.plugin.PluginLoaderTest/quest-plugin-mock-0.0.1.jar (modified) (previous)
• quest-plugin-core/src/main/java/de/ugoe/cs/quest/plugin/QuestPlugin.java (modified) (3 diffs)
• quest-plugin-guitar/src/main/java/de/ugoe/cs/quest/plugin/guitar/GUITARPlugin.java (modified) (2 diffs)
• quest-plugin-jfc/src/main/java/de/ugoe/cs/quest/plugin/jfc/JFCPlugin.java (modified) (2 diffs)
• quest-plugin-mfc/src/main/java/de/ugoe/cs/quest/plugin/mfc/MFCPlugin.java (modified) (2 diffs)
• quest-plugin-php/src/main/java/de/ugoe/cs/quest/plugin/php/PHPPlugin.java (modified) (2 diffs)

trunk/quest-plugin-core-test/src/test/java/de/ugoe/cs/quest/plugin/PluginLoaderTest.java

@@ -2 +2 @@
 
 import java.io.File;
+import java.util.Arrays;
 import java.util.Collection;
 
@@ -169 +170 @@
                 assertNotNull(plugin);
                 assertEquals("Mock Plugin", plugin.getTitle());
-                assertArrayEquals(new String[]{"de.ugoe.cs.quest.plugin.mock.commands"}, plugin.getCommandPackages());
+                assertEquals(Arrays.asList(new String[]{"de.ugoe.cs.quest.plugin.mock.commands"}), plugin.getCommandPackages());
         }
         

trunk/quest-plugin-core/src/main/java/de/ugoe/cs/quest/plugin/QuestPlugin.java

@@ -1 +1 @@
 package de.ugoe.cs.quest.plugin;
+
+import java.util.List;
 
 /**
@@ -22 +24 @@
         /**
          * <p>
-         * Collection of {@link String}s that contain the commands defined by this
-         * plug-in.
+         * {@link List} of {@link String}s that contain the commands defined by this
+         * plug-in. The List is immutable.
          * </p>
          * <p>
@@ -32 +34 @@
          * @return
          */
-        public String[] getCommandPackages();
+        public List<String> getCommandPackages();
 }

trunk/quest-plugin-guitar/src/main/java/de/ugoe/cs/quest/plugin/guitar/GUITARPlugin.java

@@ -1 +1 @@
 package de.ugoe.cs.quest.plugin.guitar;
+
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.List;
 
 import de.ugoe.cs.quest.plugin.QuestPlugin;
@@ -36 +40 @@
          */
         @Override
-        public String[] getCommandPackages() {
-                return commandPackages;
+        public List<String> getCommandPackages() {
+                return Collections.unmodifiableList(Arrays.asList(commandPackages));
         }
 

trunk/quest-plugin-jfc/src/main/java/de/ugoe/cs/quest/plugin/jfc/JFCPlugin.java

@@ -1 +1 @@
 package de.ugoe.cs.quest.plugin.jfc;
+
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.List;
 
 import de.ugoe.cs.quest.plugin.QuestPlugin;
@@ -37 +41 @@
      */
     @Override
-    public String[] getCommandPackages() {
-        return commandPackages;
+    public List<String> getCommandPackages() {
+        return Collections.unmodifiableList(Arrays.asList(commandPackages));
     }
 

trunk/quest-plugin-mfc/src/main/java/de/ugoe/cs/quest/plugin/mfc/MFCPlugin.java

@@ -1 +1 @@
 package de.ugoe.cs.quest.plugin.mfc;
+
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.List;
 
 import de.ugoe.cs.quest.plugin.QuestPlugin;
@@ -36 +40 @@
          */
         @Override
-        public String[] getCommandPackages() {
-                return commandPackages;
+        public List<String> getCommandPackages() {
+                return Collections.unmodifiableList(Arrays.asList(commandPackages));
         }
 

trunk/quest-plugin-php/src/main/java/de/ugoe/cs/quest/plugin/php/PHPPlugin.java

@@ -1 +1 @@
 package de.ugoe.cs.quest.plugin.php;
+
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.List;
 
 import de.ugoe.cs.quest.plugin.QuestPlugin;
@@ -36 +40 @@
          */
         @Override
-        public String[] getCommandPackages() {
-                return commandPackages;
+        public List<String> getCommandPackages() {
+                return Collections.unmodifiableList(Arrays.asList(commandPackages));
         }
-
 }