Changeset 806 for trunk/quest-plugin-jfc

Timestamp:

09/10/12 20:52:49 (12 years ago)

Author:

fglaser

Message:

• new helper class JFCReplayIDValidator added, that is able to extract all IDs from

GUITAR Gui file and to check if a given (generated) replayID is contained in this GUI file.

• JFCReplayIDCalculator modified for test purposes (can be initialized with a Validator

to check if IDs that are generated "on the way" are valid)

• Test Case extended for JFCReplayIDCalculator extended
• extended guimapping for freemind
• added new JFCReplayIDCalculator test ressources

Location:

trunk/quest-plugin-jfc

Files:

• data/guimappings/guimapping-freemind.txt (modified) (1 diff)
• src/main/java/de/ugoe/cs/quest/plugin/jfc/JFCReplayIDCalculator.java (modified) (4 diffs)
• src/main/java/de/ugoe/cs/quest/plugin/jfc/JFCReplayIDValidator.java (added)

trunk/quest-plugin-jfc/data/guimappings/guimapping-freemind.txt

@@ -13 +13 @@
 freemind.controller.MenuBar = de.ugoe.cs.quest.plugin.jfc.guimodel.JFCMenuBar
 freemind.view.mindmapview.ForkMainView = de.ugoe.cs.quest.plugin.jfc.guimodel.JFCGUIElement
+freemind.modes.FreeMindJFileDialog = de.ugoe.cs.quest.plugin.jfc.guimodel.JFCGUIElement

trunk/quest-plugin-jfc/src/main/java/de/ugoe/cs/quest/plugin/jfc/JFCReplayIDCalculator.java

@@ -30 +30 @@
         
         static final int prime = 31;
+        private JFCReplayIDValidator validator;
+        
+        public JFCReplayIDCalculator() {
+                this.validator = null;
+        }
+        
+        public JFCReplayIDCalculator(JFCReplayIDValidator validator){
+                this.validator = validator;
+        }
         
         /**
@@ -73 +82 @@
            long propagatedHashCode = windowHashCode;
            
-           // construct looks complicated but avoids going back and force through path
+           // added validator to check if generated component ids are known
+           if (validator != null){
+                   if (validator.validateReplayID("w" + windowHashCode)){
+                           System.out.println("ID w" + windowHashCode + " is valid.");
+                   }
+                   else{
+                           System.err.println(currentSpec + " describes an unknown component.");
+                           System.err.println("ID w" + windowHashCode + " is unknown." );
+                           System.err.println();
+                   }
+                           
+           }
+           
+           // construct looks complicated but avoids going back and forth through path
            if (iterator.hasNext())
                    currentSpec = iterator.next();
-           else
+           else{
                    currentSpec = null;
+                   // there are no subcomponents, so we use windowHashCode as hashCode
+                   hashCode = windowHashCode;
+           }
 
            // walk through component path and calculate hashcode
@@ -84 +109 @@
                    hashCode = propagatedHashCode * prime + localHashCode;
                    hashCode = (hashCode * 2) & 0xffffffffL;
+                   
+                   // added validator to check if generated component ids are known
+                   if (validator != null){
+                           if (validator.validateReplayID("w" + hashCode)){
+                                   System.out.println("ID w" + hashCode + " is valid.");
+                           }
+                           else{
+                                    System.err.println(currentSpec + " describes an unknown component.");
+                                        System.err.println("ID w" + hashCode + " is unknown." );
+                                        System.err.println();
+                           }
+                   }
 
                    if (iterator.hasNext()){
@@ -111 +148 @@
                 
                 IEventTarget target = event.getTarget();
-                JFCGUIElement jfcTarget = (JFCGUIElement) target;
+                if (!target.getPlatform().equals("JFC")){
+                        throw new IllegalArgumentException("Event target must be of type JFC.");
+                }
+                
+                JFCGUIElement currentTarget = (JFCGUIElement) target;
                 
                 // extract element path
-                JFCGUIElement currentTarget = jfcTarget;
                 while (currentTarget != null){
                         JFCGUIElementSpec currentSpec = (JFCGUIElementSpec) currentTarget.getSpecification();
+                        
+                        // new specification must be inserted at the beginning of the list
                         guiElementPath.add(0, currentSpec);
                         currentTarget = (JFCGUIElement) currentTarget.getParent();