Changeset 834 for trunk/quest-plugin-jfc/src/main/java

Timestamp:

09/20/12 10:18:20 (12 years ago)

Author:

pharms

Message:

• improved memory usage

File:

• trunk/quest-plugin-jfc/src/main/java/de/ugoe/cs/quest/plugin/jfc/JFCTraceCorrector.java (modified) (5 diffs)

trunk/quest-plugin-jfc/src/main/java/de/ugoe/cs/quest/plugin/jfc/JFCTraceCorrector.java

@@ -318 +318 @@
             currentSession.dump(outFile);
             currentSession = null;
+            allSources.clear();
         }
         else if (qName.equals("newsession")) {
@@ -324 +325 @@
             currentSession.dump(outFile);
             currentSession = null;
+            allSources.clear();
         }
         else if (qName.equals("event")) {
@@ -330 +332 @@
         }
         else if (qName.equals("source")) {
-            rememberSource(currentSource);
-            currentEvent.source = currentSource;
+            currentEvent.source = getUniqueSource(currentSource);
             currentSource = null;
         }
@@ -351 +352 @@
      * @param source the source to store
      */
-    private void rememberSource(Source source) {
+    private Source getUniqueSource(Source source) {
         String toStringValue = getToStringParam(source);
-        
-        List<Source> sources = allSources.get(toStringValue);
-        
-        if (sources == null) {
-            sources = new ArrayList<Source>();
-            allSources.put(toStringValue, sources);
-        }
-        
-        sources.add(source);
+
+        Source existingSource = findSource(toStringValue);
+        
+        if (existingSource == null) {
+            List<Source> sources = allSources.get(toStringValue);
+        
+            if (sources == null) {
+                sources = new ArrayList<Source>();
+                allSources.put(toStringValue, sources);
+            }
+            
+            sources.add(source);
+            existingSource = source;
+        }
+        
+        return existingSource;
     }
 
@@ -385 +393 @@
             for (Source candidate : candidates) {
                 if (toStringValue.equals(getToStringParam(candidate)) &&
-                        (candidate.components != null) && (candidate.components.size() > 0))
+                    (candidate.components != null) && (candidate.components.size() > 0))
                 {
                     existingSource = candidate;
+                    break;
                 }
             }