Changeset 872

Timestamp:

10/12/12 15:16:25 (12 years ago)

Author:

pharms

Message:

• removed find bug warnings

Location:

trunk/autoquest-htmlmonitor/src/main/java/de/ugoe/cs/autoquest/htmlmonitor

Files:

• HtmlMonitorLogManager.java (modified) (1 diff)
• HtmlMonitorMessageListener.java (modified) (2 diffs)
• HtmlMonitorOutputWriter.java (modified) (4 diffs)
• HtmlMonitorServlet.java (modified) (3 diffs)

trunk/autoquest-htmlmonitor/src/main/java/de/ugoe/cs/autoquest/htmlmonitor/HtmlMonitorLogManager.java

@@ -24 +24 @@
 class HtmlMonitorLogManager implements HtmlMonitorComponent, HtmlMonitorMessageListener {
     
+    /**  */
+    private static final long serialVersionUID = 1L;
+
     /**
      * the timeout after which a writer of an inactive client is closed

trunk/autoquest-htmlmonitor/src/main/java/de/ugoe/cs/autoquest/htmlmonitor/HtmlMonitorMessageListener.java

@@ -1 +1 @@
 package de.ugoe.cs.autoquest.htmlmonitor;
+
+import java.io.Serializable;
 
 /**
@@ -9 +11 @@
  * @author Patrick Harms
  */
-public interface HtmlMonitorMessageListener {
+public interface HtmlMonitorMessageListener extends Serializable {
 
     /**

trunk/autoquest-htmlmonitor/src/main/java/de/ugoe/cs/autoquest/htmlmonitor/HtmlMonitorOutputWriter.java

@@ -8 +8 @@
 import java.io.PrintWriter;
 import java.text.DecimalFormat;
+
+import de.ugoe.cs.util.console.Console;
 
 /**
@@ -30 +32 @@
 public class HtmlMonitorOutputWriter implements HtmlMonitorComponent, HtmlMonitorMessageListener {
     
+    /**  */
+    private static final long serialVersionUID = 1L;
+
     /**
      * the maximum size of an individual log file
@@ -102 +107 @@
             
                 if (!clientLogDir.exists()) {
-                    clientLogDir.mkdirs();
+                    if (!clientLogDir.mkdirs()) {
+                        throw new HtmlMonitorException("client log file directory " + clientLogDir +
+                                                       " can not be created");
+                    }
                 }
                 else if (!clientLogDir.isDirectory()) {
@@ -278 +286 @@
         while (checkFile.exists());
     
-        logFile.renameTo(checkFile);
-        logFileIndex++;
-        logFile = new File(clientLogDir, getLogFileName(-1));
+        if (!logFile.renameTo(checkFile)) {
+            Console.printerrln("could not rename log file " + logFile + " to " + checkFile +
+                               ". Will not perform log rotation.");
+        }
+        else {
+            logFileIndex++;
+            logFile = new File(clientLogDir, getLogFileName(-1));
+        }
     }
 

trunk/autoquest-htmlmonitor/src/main/java/de/ugoe/cs/autoquest/htmlmonitor/HtmlMonitorServlet.java

@@ -62 +62 @@
         Object value = null;
         try {
-            value = JSONValue.parseWithException(new InputStreamReader(request.getInputStream()));
+            value = JSONValue.parseWithException
+                (new InputStreamReader(request.getInputStream(), "UTF-8"));
             
             if (!(value instanceof JSONObject)) {
@@ -325 +326 @@
             else if ((int.class.equals(clazz)) || (Integer.class.equals(clazz))) {
                 try {
-                    result = (T) new Integer(Integer.parseInt((String) value));
+                    result = (T) Integer.valueOf(Integer.parseInt((String) value));
                 }
                 catch (NumberFormatException e) {
@@ -334 +335 @@
             else if ((long.class.equals(clazz)) || (Long.class.equals(clazz))) {
                 try {
-                    result = (T) new Long(Long.parseLong((String) value));
+                    result = (T) Long.valueOf(Long.parseLong((String) value));
                 }
                 catch (NumberFormatException e) {