Changeset 1918 for trunk/autoquest-core-usability/src/main/java/de/ugoe/cs/autoquest/usability/MissingFeedbackRule.java

Timestamp:

03/12/15 15:50:28 (9 years ago)

Author:

pharms

Message:

• extension with further smell detections
• may not fully work. But Hudson is more happy because compile errors should be gone

File:

• trunk/autoquest-core-usability/src/main/java/de/ugoe/cs/autoquest/usability/MissingFeedbackRule.java (modified) (4 diffs)

trunk/autoquest-core-usability/src/main/java/de/ugoe/cs/autoquest/usability/MissingFeedbackRule.java

@@ -78 +78 @@
             // be considered as usability smell.
             
-            UsabilityDefectSeverity severity = UsabilityDefectSeverity.getSeverity
-                (entry.getValue(), 2000, 1000, 500, 50, entry.getKey(), taskModel);
-
-            if (severity != null) {
+            UsabilitySmellIntensity intensity =
+                UsabilitySmellIntensity.getIntensity(entry.getValue(), entry.getKey(), taskModel);
+
+            if (intensity != null) {
                 Map<String, Object> parameters = new HashMap<String, Object>();
 
@@ -88 +88 @@
                 long cummulatedWaitingTime = 0;
                 int numberOfAdditionalClicks = 0;
-                
-                System.out.println("\n\n#################################");
                 
                 Event exampleEvent = null;
@@ -101 +99 @@
                         for (List<Event> subsequence : clicksOnIdenticalButton) {
                             exampleEvent = subsequence.get(0);
-                            System.out.println(exampleEvent.getTimestamp());
                             
                             Event endEvent = subsequence.get(subsequence.size() - 1);
@@ -123 +120 @@
                 parameters.put("task", entry.getKey());
                 
-                results.addDefect
-                    (severity, UsabilityDefectDescription.MISSING_FEEDBACK, parameters);
+                results.addSmell(entry.getKey(), intensity,
+                                 UsabilitySmellDescription.MISSING_FEEDBACK, parameters);
             }
         }