Changeset 1918 for trunk/autoquest-core-usability/src/main/java/de/ugoe/cs/autoquest/usability/TextInputStatisticsRule.java

Timestamp:

03/12/15 15:50:28 (9 years ago)

Author:

pharms

Message:

• extension with further smell detections
• may not fully work. But Hudson is more happy because compile errors should be gone

File:

• trunk/autoquest-core-usability/src/main/java/de/ugoe/cs/autoquest/usability/TextInputStatisticsRule.java (modified) (7 diffs)

trunk/autoquest-core-usability/src/main/java/de/ugoe/cs/autoquest/usability/TextInputStatisticsRule.java

@@ -84 +84 @@
         int ratio = 1000 * allTextFieldInputs / statistics.getNoOfAllEvents();
 
-        // TODO comment magic numbers
-        UsabilityDefectSeverity severity = UsabilityDefectSeverity.getSeverity
-            (ratio, 900, 700, 500, 300);
+        UsabilitySmellIntensity severity = UsabilitySmellIntensity.getIntensity(ratio);
         
         if (severity != null) {
@@ -92 +90 @@
             parameters.put("textInputRatio", (ratio / 10));
 
-            results.addDefect
-                (severity, UsabilityDefectDescription.TEXT_FIELD_INPUT_RATIO, parameters);
+            results.addSmell
+                (severity, UsabilitySmellDescription.TEXT_FIELD_INPUT_RATIO, parameters);
         }
     }
@@ -117 +115 @@
                 1000 * noOfUsagesOfTextField1WithSameTextInTextField2 / noOfUsagesOfTextField2;
 
-            createTextFieldEntryRepetitionDefect(ratioTextField1, entry.textField1,
+            createTextFieldEntryRepetitionSmell(ratioTextField1, entry.textField1,
                                                  entry.textField2, results);
             
-            createTextFieldEntryRepetitionDefect(ratioTextField2, entry.textField2,
+            createTextFieldEntryRepetitionSmell(ratioTextField2, entry.textField2,
                                                  entry.textField1, results);
             
@@ -129 +127 @@
      *
      */
-    private void createTextFieldEntryRepetitionDefect(int                       ratioOfEqualEntries,
+    private void createTextFieldEntryRepetitionSmell(int                       ratioOfEqualEntries,
                                                       ITextField                textField1,
                                                       ITextField                textField2,
                                                       UsabilityEvaluationResult results)
     {
-        // TODO comment magic numbers
-        UsabilityDefectSeverity severity = UsabilityDefectSeverity.getSeverity
-            (ratioOfEqualEntries, 900, 500, 200, 100);
+        UsabilitySmellIntensity severity =
+            UsabilitySmellIntensity.getIntensity(ratioOfEqualEntries);
         
         if (severity != null) {
@@ -144 +141 @@
             parameters.put("textField2", textField2);
 
-            results.addDefect
-                (severity, UsabilityDefectDescription.TEXT_FIELD_INPUT_REPETITIONS, parameters);
+            results.addSmell
+                (severity, UsabilitySmellDescription.TEXT_FIELD_INPUT_REPETITIONS, parameters);
         }
     }
@@ -172 +169 @@
             int ratio = 1000 * noLetterOrDigitCount / allCharactersCount;
 
-            UsabilityDefectSeverity severity =
-                UsabilityDefectSeverity.getSeverity(ratio,
-                                                    100, // every 10th sign
-                                                    50, // every 20th sign
-                                                    20, // every 50th sign
-                                                    10 // every 100th sign
-                                                    );
+            UsabilitySmellIntensity severity = UsabilitySmellIntensity.getIntensity(ratio);
 
             if (severity != null) {
@@ -185 +176 @@
                 parameters.put("noLetterOrDigitRatio", (ratio / 10));
 
-                results.addDefect
-                    (severity, UsabilityDefectDescription.TEXT_FIELD_NO_LETTER_OR_DIGIT_RATIO,
+                results.addSmell
+                    (severity, UsabilitySmellDescription.TEXT_FIELD_NO_LETTER_OR_DIGIT_RATIO,
                      parameters);
             }