Changeset 2042 for trunk/autoquest-core-usability/src/main/java/de/ugoe/cs/autoquest/usability/DefaultValueRule.java

Timestamp:

10/20/15 10:11:04 (9 years ago)

Author:

pharms

Message:

• finalized smell detection for phd thesis

File:

• trunk/autoquest-core-usability/src/main/java/de/ugoe/cs/autoquest/usability/DefaultValueRule.java (modified) (5 diffs)

trunk/autoquest-core-usability/src/main/java/de/ugoe/cs/autoquest/usability/DefaultValueRule.java

@@ -29 +29 @@
 
 import de.ugoe.cs.autoquest.eventcore.Event;
+import de.ugoe.cs.autoquest.eventcore.gui.MouseClick;
 import de.ugoe.cs.autoquest.eventcore.gui.TextInput;
 import de.ugoe.cs.autoquest.eventcore.gui.ValueSelection;
 import de.ugoe.cs.autoquest.eventcore.guimodel.GUIModel;
 import de.ugoe.cs.autoquest.eventcore.guimodel.ICheckBox;
+import de.ugoe.cs.autoquest.eventcore.guimodel.IComboBox;
 import de.ugoe.cs.autoquest.eventcore.guimodel.IGUIElement;
 import de.ugoe.cs.autoquest.eventcore.guimodel.IGUIElementSpec;
@@ -136 +138 @@
             maxObserved = Math.max(maxObserved, selectedValue.getValue());
             
-            if (mostOftenSelected.size() > 0) {
-                ListIterator<Object> iterator = mostOftenSelected.listIterator();
-                while (iterator.hasNext()) {
-                    if (selectedValues.get(iterator.next()) < selectedValue.getValue()) {
-                        iterator.previous();
-                        iterator.add(selectedValue.getKey());
-                    
-                        while (mostOftenSelected.size() > 5) {
-                            mostOftenSelected.removeLast();
-                        }
-                    
-                        break;
-                    }
-                }
-            }
-            else {
+            boolean added = false;
+            ListIterator<Object> iterator = mostOftenSelected.listIterator();
+            while (iterator.hasNext()) {
+                if (selectedValues.get(iterator.next()) < selectedValue.getValue()) {
+                    iterator.previous();
+                    iterator.add(selectedValue.getKey());
+                    added = true;
+                    break;
+                }
+            }
+            
+            if (!added) {
                 mostOftenSelected.add(selectedValue.getKey());
+            }
+            
+            while (mostOftenSelected.size() > 5) {
+                mostOftenSelected.removeLast();
             }
         }
@@ -163 +165 @@
         }
         
-        if ((expected.length == 1) ||
+        if ((expected.length > 1) &&
             (new ChiSquareTest().chiSquareTest(expected, observed, 0.05)))
         {
@@ -218 +220 @@
      */
     private boolean isValueSelection(ITaskInstance instance) {
-        return (instance instanceof IEventTaskInstance) &&
-            ((((IEventTaskInstance) instance).getEvent().getType() instanceof TextInput) ||
-             (((IEventTaskInstance) instance).getEvent().getType() instanceof ValueSelection));
+        if (instance instanceof IEventTaskInstance) {
+            Event event = ((IEventTaskInstance) instance).getEvent();
+        
+            if ((event.getType() instanceof TextInput) ||
+                (event.getType() instanceof ValueSelection))
+            {
+                return true;
+            }
+            
+            if (("JFC".equals(event.getTarget().getPlatform())) &&
+                (event.getTarget() instanceof ICheckBox) &&
+                (event.getType() instanceof MouseClick))
+            {
+                return true;
+            }
+        }
+        
+        return false;
     }
 
@@ -439 +456 @@
                         ((ValueSelection<?>) valueChange.getEvent().getType()).getSelectedValue();
                     
-                    if ((target instanceof IRadioButton) || (target instanceof ICheckBox)) {
+                    if ((target.target instanceof IRadioButton) ||
+                        (target.target instanceof ICheckBox))
+                    {
                         selectedValue = selectedValue + " (" + target + ")";
+                    }
+                    else if (target.target instanceof IComboBox) {
+                        if (selectedValue == null) {
+                            // this may have happened due to the recording issue that selected
+                            // values of combo boxes are not logged correctly. In this case,
+                            // pretend to have the a random value selected
+                            selectedValue = "randomValueDueToRecordingBug_" + Math.random(); 
+                        }
+                    }
+                }
+                else if (valueChange.getEvent().getType() instanceof MouseClick) {
+                    if ((target.target instanceof IRadioButton) ||
+                        (target.target instanceof ICheckBox))
+                    {
+                        selectedValue = target.toString();
+                    }
+                    else {
+                        throw new IllegalStateException("the implementation needs to be extended " +
+                                                        "to fully support clicks as value changes");
                     }
                 }