Changeset 2126 for trunk/autoquest-core-tasktrees/src/main/java/de/ugoe/cs/autoquest/tasktrees/taskequality/GUIEventTaskComparisonRule.java

Timestamp:

05/03/16 17:06:33 (8 years ago)

Author:

pharms

Message:

• implemented some performance improvements

File:

• trunk/autoquest-core-tasktrees/src/main/java/de/ugoe/cs/autoquest/tasktrees/taskequality/GUIEventTaskComparisonRule.java (modified) (3 diffs)

trunk/autoquest-core-tasktrees/src/main/java/de/ugoe/cs/autoquest/tasktrees/taskequality/GUIEventTaskComparisonRule.java

@@ -43 +43 @@
 import de.ugoe.cs.autoquest.eventcore.guimodel.IText;
 import de.ugoe.cs.autoquest.eventcore.guimodel.IToolTip;
+import de.ugoe.cs.autoquest.tasktrees.treeifc.IEventTask;
 import de.ugoe.cs.autoquest.tasktrees.treeifc.IEventTaskInstance;
 import de.ugoe.cs.autoquest.tasktrees.treeifc.ITask;
@@ -68 +69 @@
     @Override
     public boolean isApplicable(ITask task1, ITask task2) {
-        for (ITaskInstance instance : task1.getInstances()) {
-            if ((!(instance instanceof IEventTaskInstance)) ||
-                (!(((IEventTaskInstance) instance).getEvent().getType() instanceof IInteraction)))
-            {
-                return false;
-            }
-        }
-        
-        for (ITaskInstance instance : task2.getInstances()) {
-            if ((!(instance instanceof IEventTaskInstance)) ||
-                (!(((IEventTaskInstance) instance).getEvent().getType() instanceof IInteraction)))
-            {
-                return false;
-            }
+        if (!(task1 instanceof IEventTask)) {
+            return false;
+        }
+        
+        if (!(task2 instanceof IEventTask)) {
+            return false;
+        }
+        
+        IEventTaskInstance instance1 = (IEventTaskInstance) task1.getInstances().iterator().next();
+        
+        if (!(instance1.getEvent().getType() instanceof IInteraction)) {
+            return false;
+        }
+        
+        IEventTaskInstance instance2 = (IEventTaskInstance) task2.getInstances().iterator().next();
+        
+        if (!(instance2.getEvent().getType() instanceof IInteraction)) {
+            return false;
         }
         
@@ -178 +183 @@
         Collection<ITaskInstance> taskInstances1 = task1.getInstances();
         Collection<ITaskInstance> taskInstances2 = task2.getInstances();
+        
+        if (taskInstances1.size() > taskInstances2.size()) {
+            // it may be the case, that all instances of first task match already the first instance
+            // of the second task. In this case, the below for loops would iterate of all instances
+            // of the first task but the internal loop would always break. But if the first task
+            // has many more instances than the second task, performing the comparison the other
+            // way around would result in less comparisons. Hence, we switch the task instance lists
+            // to have fewer comparisons.
+            Collection<ITaskInstance> tmp = taskInstances1;
+            taskInstances1 = taskInstances2;
+            taskInstances2 = tmp;
+        }
         
         TaskEquality checkedEquality =