Changeset 284 for trunk/EventBenchConsole/src/de/ugoe/cs/eventbench/swing/DlgInsert.java

Timestamp:

12/09/11 11:22:08 (13 years ago)

Author:

sherbold

Message:

• fixed some code smells

File:

• trunk/EventBenchConsole/src/de/ugoe/cs/eventbench/swing/DlgInsert.java (modified) (2 diffs)

trunk/EventBenchConsole/src/de/ugoe/cs/eventbench/swing/DlgInsert.java

@@ -512 +512 @@
                 }
                 // TextEquals
-                else if (selectedItem == "TextEquals") {
+                else if (selectedItem.equals("TextEquals")) {
                         if (textFieldExpectedValue.getText().length() == 0) {
                                 JOptionPane.showMessageDialog(null,
@@ -539 +539 @@
 
                                 // get all parents
-                                String target = "";
+                                StringBuilder target = new StringBuilder();
                                 for (int i = 0; i < splitted.length; i++) {
-                                        target += splitted[i];
+                                        target.append(splitted[i]);
                                 }
                                 // ***
 
-                                TextEqualsReplay text = new TextEqualsReplay(textFieldExpectedValue.getText(),target);
+                                TextEqualsReplay text = new TextEqualsReplay(textFieldExpectedValue.getText(),target.toString());
 
                                 AssertEvent<TextEqualsReplay> e = new AssertEvent<TextEqualsReplay>(